Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date-picker): Basic date picker #1903

Closed
wants to merge 1 commit into from
Closed

feat(date-picker): Basic date picker #1903

wants to merge 1 commit into from

Conversation

Frly
Copy link

@Frly Frly commented Nov 17, 2016

Basic Date Picker Component

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 17, 2016
@Frly Frly changed the title Udate Date Picker feat(date-picker): Basic date picker Nov 17, 2016
@jelbourn
Copy link
Member

@Frly the first step on a large contribution like this is to chat with us on the relevant issue (#675). Before going down the road of implementation, we'd need to have a solid plan for everything I mentioned in #1746

For the datepicker specifically, there is a revision of the spec in the works. We don't want to build/maintain a picker before that revision is ready.

I encourage you to release your datepicker as a standalone package- I know there any many people that would like to use it!

@jelbourn jelbourn closed this Nov 17, 2016
@Frly
Copy link
Author

Frly commented Nov 17, 2016

@jelbourn The service overlay is working, I have not uploaded completely, it is missing:

  • Support for accessibility
  • Support for i18n (RTL)
  • Unit tests

This date selector can select between two dates

@Frly Frly mentioned this pull request Nov 17, 2016
@yuxin6052
Copy link

@Frly could you share you sourcecode of basic datepicker

@fxck
Copy link
Contributor

fxck commented Nov 23, 2016

@yuxin6052 this is a pull request... you can see all the code in the files changed tab https://github.com/angular/material2/pull/1903/files

@fxck fxck mentioned this pull request Dec 20, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants